Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexer-agent: Improve robustness of DAI contract contract calls #825

Merged
merged 1 commit into from
Nov 27, 2023
Merged

indexer-agent: Improve robustness of DAI contract contract calls #825

merged 1 commit into from
Nov 27, 2023
+10 −1

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Nov 22, 2023

Changes

  • Add fallback if decimals() call to DAI contract fails (default to 18)

@fordN fordN self-assigned this Nov 22, 2023
@fordN fordN added enhancement New feature or request indexer-agent labels Nov 22, 2023
kapoorabhishek24
kapoorabhishek24 approved these changes Nov 22, 2023
View reviewed changes
Copy link

@kapoorabhishek24 kapoorabhishek24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fordN fordN merged commit 82fb292 into main Nov 27, 2023
9 checks passed
@fordN fordN deleted the ford/stablecoin-contract-call-robustness branch November 27, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abarmat abarmat abarmat approved these changes

@kapoorabhishek24 kapoorabhishek24 kapoorabhishek24 approved these changes

Assignees

@fordN fordN

Labels
enhancement New feature or request indexer-agent
Projects
Indexer
Status: 🚗 Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fordN @abarmat @kapoorabhishek24