Added transaction signing #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannis
approved these changes
Jun 12, 2020
Jannis
approved these changes
Jun 13, 2020
|
Looks like I approved twice 😂 |
Maybe you approved again after adding the memory locking? 🤷 Thanks for the review, appreciated! |
|
I reviewed with the memory locking, but I think I simply had two browser tabs open and one hadn't updated yet to show my first approval. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Everything in internal/types.rs was moved out of internal/mod.rs, the only thing added was a comment (not much review required, but git doesn't know that)
Added
signed_call_with_confirmationstorust-web3here: tomusdrw/rust-web3#352Use
signed_call_with_confirmationswithin the contractAdded
SafeSecretKeyto securely manage private memory in as close to a foolproof way as possible. Might separate this into a separate crate.