add support to pass properties to graphiql. For now only editorTheme #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with |
|
This PR could be updated from current |
sibelius
approved these changes
Apr 28, 2020
|
The branch has been rebased, links have been updated. It's ready to be merged with fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to pass
editorThemeparameter toGraphiQLby replacinggraphiql: booleanwithgraphiql: boolean | object.Also it opens the way how anyone in future may add support for any of
graphiqlproperties. So if some one would need to use customstoragefor example, he would need to obtain it as another property ofgraphiqlobject