Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required schema fields are not required in GraphQL types #224

Closed
koredefashokun opened this issue May 17, 2020 · 1 comment
Closed

Required schema fields are not required in GraphQL types #224

koredefashokun opened this issue May 17, 2020 · 1 comment
Labels
released

Comments

@koredefashokun
Copy link

koredefashokun commented May 17, 2020 •
edited

I noticed that the GraphQL types don't make use of the required option on Mongoose filters. Is there a reason for this? It would also be nice to have an option to make the types returned from the resolvers required as well, i.e.

storeOne: Store!
storeMany: [Store!]!

instead of the default, which looks something like this:

storeOne: Store
storeMany: [Store]

The main reason I have an issue with this is that handling conditionals for values that will always be returned on the frontend is a huge pain.
nodkz added a commit that referenced this issue Jul 2, 2020
@nodkz
feat: required fields from mongoose schema became required in GraphQL
d3d28da 
closes #224
@nodkz nodkz closed this as completed in 6f20e1d Jul 2, 2020
@nodkz
Copy link
Member

nodkz commented Jul 2, 2020

🎉 This issue has been resolved in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nodkz nodkz added the released label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nodkz @koredefashokun