Skip to content

Commit

Permalink
test: remove redundant any coercion
Browse files Browse the repository at this point in the history
  • Loading branch information
nodkz committed Apr 30, 2021
1 parent bac71df commit 920e7ab
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
16 changes: 8 additions & 8 deletions src/__tests__/ObjectTypeComposer-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1109,28 +1109,28 @@ describe('ObjectTypeComposer', () => {
name: 'findById',
resolve: () => '123',
});
expect(await tc.getResolver('findById').resolve({} as any)).toBe('123');
expect(await tc.getResolver('findById').resolve({})).toBe('123');

tc.wrapResolverResolve('findById', (next) => async (rp) => {
const prev = await next(rp);
return `${prev}456`;
});
expect(await tc.getResolver('findById').resolve({} as any)).toBe('123456');
expect(await tc.getResolver('findById').resolve({})).toBe('123456');
});

it('wrapResolver() should wrap resolver via callback', async () => {
tc.addResolver({
name: 'update',
resolve: () => '123',
});
expect(await tc.getResolver('update').resolve({} as any)).toBe('123');
expect(await tc.getResolver('update').resolve({})).toBe('123');
const prevResolver = tc.getResolver('update');

tc.wrapResolver('update', (resolver) => {
resolver.resolve = () => '456'; // eslint-disable-line
return resolver;
});
expect(await tc.getResolver('update').resolve({} as any)).toBe('456');
expect(await tc.getResolver('update').resolve({})).toBe('456');
expect(tc.getResolver('update')).not.toBe(prevResolver);
expect((prevResolver as any).resolve(undefined)).toBe('123');
});
Expand All @@ -1144,15 +1144,15 @@ describe('ObjectTypeComposer', () => {
},
resolve: () => '123',
});
expect(await tc.getResolver('update').resolve({} as any)).toBe('123');
expect(await tc.getResolver('update').resolve({})).toBe('123');

tc.wrapResolverAs('updateExt', 'update', (resolver) => {
resolver.resolve = () => '456'; // eslint-disable-line
resolver.addArgs({ c: 'Boolean' });
return resolver;
});
expect(await tc.getResolver('updateExt').resolve({} as any)).toBe('456');
expect(await tc.getResolver('update').resolve({} as any)).toBe('123');
expect(await tc.getResolver('updateExt').resolve({})).toBe('456');
expect(await tc.getResolver('update').resolve({})).toBe('123');

expect(tc.getResolver('update').getArgNames()).toEqual(['a', 'b']);
expect(tc.getResolver('updateExt').getArgNames()).toEqual(['a', 'b', 'c']);
Expand Down Expand Up @@ -1180,7 +1180,7 @@ describe('ObjectTypeComposer', () => {
return '123';
},
});
expect(await tc.getResolver('update', [mw1, mw2]).resolve({} as any)).toBe('123');
expect(await tc.getResolver('update', [mw1, mw2]).resolve({})).toBe('123');
expect(log).toEqual(['m1.before', 'm2.before', 'call update', 'm2.after', 'm1.after']);
});
});
Expand Down
14 changes: 7 additions & 7 deletions src/__tests__/Resolver-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ describe('Resolver', () => {
await newResolver.resolve({
args: { filter: { age: 15, isActive: false } },
someKey: 16,
} as any);
});

expect(rpSnap.rawQuery).toEqual({
age: { $gt: 15 },
Expand Down Expand Up @@ -830,7 +830,7 @@ describe('Resolver', () => {
sortTypeNameFallback: 'SortEnum',
});

newResolver.resolve({ args: { sort: 'PRICE_ASC' }, query } as any);
newResolver.resolve({ args: { sort: 'PRICE_ASC' }, query });
expect(rpSnap.args.sort).toEqual({ price: 1 });
expect(whereSnap).toEqual({ price: { $gt: 0 } });
});
Expand Down Expand Up @@ -934,8 +934,8 @@ describe('Resolver', () => {
source: { id: 1 },
args: { limit: 1 },
context: { isAdmin: true, db: {} },
info: { fieldName: 'a', otherAstFields: {} },
} as any);
info: { fieldName: 'a', otherAstFields: {} } as any,
});

expect(console.log.mock.calls[0]).toEqual(['ResolverResolveParams for User.find():']);
expect(console.dir.mock.calls[0]).toEqual([
Expand Down Expand Up @@ -963,7 +963,7 @@ describe('Resolver', () => {
r1.debugParams('args, args.sort, source.name').resolve({
source: { id: 1, name: 'Pavel' },
args: { limit: 1, sort: 'id' },
} as any);
});

expect(console.log.mock.calls[0]).toEqual(['ResolverResolveParams for User.find():']);
expect(console.dir.mock.calls[0]).toEqual([
Expand Down Expand Up @@ -1052,7 +1052,7 @@ describe('Resolver', () => {
.resolve({
source: { id: 1, name: 'Pavel' },
args: { limit: 1, sort: 'id' },
} as any);
});

expect(console.time.mock.calls[0]).toEqual(['Execution time for User.find()']);
expect(console.timeEnd.mock.calls[0]).toEqual(['Execution time for User.find()']);
Expand Down Expand Up @@ -1210,7 +1210,7 @@ describe('Resolver', () => {
return res;
};

const res = await r.withMiddlewares([mw1, mw2]).resolve({} as any);
const res = await r.withMiddlewares([mw1, mw2]).resolve({});
expect(res).toBe('users result');
expect(log).toEqual(['m1.before', 'm2.before', 'call User.find()', 'm2.after', 'm1.after']);
});
Expand Down

0 comments on commit 920e7ab

Please sign in to comment.