fix: problem "schema contains multiple types named XXX" when merging …

…several schemas

related #287

src/EnumTypeComposer.js

@@ -146,6 +146,7 @@ export class EnumTypeComposer<TContext> {
     // add itself to TypeStorage on create
     // it avoids recursive type use errors
     this.schemaComposer.set(graphqlType, this);
+    this.schemaComposer.set(graphqlType.name, this);
 
     this._gqcFields = convertEnumValuesToConfig(this._gqType.getValues(), this.schemaComposer);
 

src/InputTypeComposer.js

@@ -178,6 +178,7 @@ export class InputTypeComposer<TContext> {
     // add itself to TypeStorage on create
     // it avoids recursive type use errors
     this.schemaComposer.set(graphqlType, this);
+    this.schemaComposer.set(graphqlType.name, this);
 
     if (graphqlVersion >= 14) {
       this._gqcFields = convertInputFieldMapToConfig(this._gqType._fields, this.schemaComposer);

src/InterfaceTypeComposer.js

@@ -211,6 +211,7 @@ export class InterfaceTypeComposer<TSource, TContext> {
     // add itself to TypeStorage on create
     // it avoids recursive type use errors
     this.schemaComposer.set(graphqlType, this);
+    this.schemaComposer.set(graphqlType.name, this);
 
     if (graphqlVersion >= 15) {
       this._gqcFields = convertObjectFieldMapToConfig(this._gqType._fields, this.schemaComposer);

src/ObjectTypeComposer.js

@@ -324,6 +324,10 @@ export class ObjectTypeComposer<TSource, TContext> {
     // add itself to TypeStorage on create
     // it avoids recursive type use errors
     this.schemaComposer.set(graphqlType, this);
+    const typename = graphqlType.name;
+    if (typename !== 'Query' && typename !== 'Mutation' && typename !== 'Subscription') {
+      this.schemaComposer.set(typename, this);
+    }
 
     if (graphqlVersion >= 14) {
       this._gqcFields = convertObjectFieldMapToConfig(this._gqType._fields, this.schemaComposer);

src/ScalarTypeComposer.js

@@ -120,6 +120,7 @@ export class ScalarTypeComposer<TContext> {
     // add itself to TypeStorage on create
     // it avoids recursive type use errors
     this.schemaComposer.set(graphqlType, this);
+    this.schemaComposer.set(graphqlType.name, this);
 
     let serialize;
     let parseValue;

src/UnionTypeComposer.js

@@ -181,6 +181,7 @@ export class UnionTypeComposer<TSource, TContext> {
     // add itself to TypeStorage on create
     // it avoids recursive type use errors
     this.schemaComposer.set(graphqlType, this);
+    this.schemaComposer.set(graphqlType.name, this);
 
     let types = [];
     if (graphqlVersion >= 14) {

src/__tests__/EnumTypeComposer-test.js

@@ -198,7 +198,7 @@ describe('EnumTypeComposer', () => {
     });
 
     it('should create TC without values from string', () => {
-      const myTC = EnumTypeComposer.create('MyEnum', schemaComposer);
+      const myTC = EnumTypeComposer.create('MyEnum123', schemaComposer);
       expect(myTC.getFieldNames()).toEqual([]);
     });
 

src/__tests__/ObjectTypeComposer-test.js

@@ -784,7 +784,7 @@ describe('ObjectTypeComposer', () => {
       expect(schemaComposer.getOTC('SomeUser')).toBe(SomeUserTC);
     });
 
-    it('should create type and NOTE store root types in schemaComposer', () => {
+    it('should create type and NOT to store root types in schemaComposer', () => {
       ObjectTypeComposer.create('Query', schemaComposer);
       expect(schemaComposer.has('Query')).toBeFalsy();
 

src/__tests__/github_issues/107-test.js

@@ -70,7 +70,7 @@ describe('github issue #107 merge Schema types on GQL', () => {
     expect(RemoteAccessTC.getTypeName()).toEqual('Access');
   });
 
-  it('schema stiching on Query', async () => {
+  it('schema stitching on Query', async () => {
     const RemoteQueryType: any = remoteSchema._queryType;
     const RemoteQueryTC = schemaComposer.createObjectTC(RemoteQueryType);
 
@@ -105,7 +105,7 @@ describe('github issue #107 merge Schema types on GQL', () => {
     });
   });
 
-  it('schema stiching on Query.remote', async () => {
+  it('schema stitching on Query.remote', async () => {
     const RemoteQueryType: any = remoteSchema._queryType;
     const RemoteQueryTC = schemaComposer.createObjectTC(RemoteQueryType);
 

src/__tests__/github_issues/287-test.js

@@ -118,4 +118,96 @@ describe('github issue #287: Can we merge schemas with overriding types in field
       type Subscription
     `);
   });
+
+  it('should not throw contains multiple types named "Node"', () => {
+    if (graphqlVersion < 15) return;
+
+    const typeDefsA = `
+      type Mutation {
+        createPost(data: String!): Post!
+      }
+
+      interface Node {
+        id: ID!
+      }
+
+      type Post implements Node {
+        id: ID!
+        title: String!
+      }
+
+      type PostConnection {
+        edges: [PostEdge]!
+      }
+
+      type PostEdge {
+        node: Post!
+      }
+
+      type PostSubscriptionPayload {
+        node: Post
+      }
+
+      input PostUpdateManyMutationInput {
+        title: String
+        content: String
+      }
+
+      type Query {
+        posts(first: Int, last: Int): [Post]!
+        postsConnection(first: Int, last: Int): PostConnection!
+        node(id: ID!): Node
+      }
+
+      type Subscription {
+        post(where: String): PostSubscriptionPayload
+      }
+    `;
+
+    const typeDefsB = `
+      type Mutation {
+        createPost(data: String!): Post!
+      }
+
+      interface Node {
+        id: ID!
+      }
+
+      type Post implements Node {
+        id: ID!
+        content: String
+      }
+
+      type PostConnection {
+        edges: [PostEdge]!
+      }
+
+      type PostEdge {
+        node: Post!
+      }
+
+      type PostSubscriptionPayload {
+        node: Post
+      }
+
+      type Query {
+        posts: [Post]!
+        postsConnection: PostConnection!
+        node(id: ID!): Node
+      }
+
+      type Subscription {
+        post(where: String): PostSubscriptionPayload
+      }
+      `;
+
+    const schemaA = buildSchema(typeDefsA);
+    const schemaB = buildSchema(typeDefsB);
+
+    const sc = new SchemaComposer(schemaA);
+    sc.merge(schemaB);
+    expect(() => {
+      sc.buildSchema();
+    }).not.toThrow(/contains multiple types named "Node"/);
+  });
 });