Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check reset password token mutation #10

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

mcelicalderon
Copy link
Member

No description provided.

@mcelicalderon mcelicalderon force-pushed the check-reset-password-token branch 2 times, most recently from eb75708 to c6eb381 Compare September 9, 2019 01:16
@mcelicalderon mcelicalderon marked this pull request as ready for review September 9, 2019 01:16
@@ -31,6 +31,11 @@ def controller
context[:controller]
end

def set_auth_headers(resource)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_auth_headers is already present in line 63 of this fiel

private

def client_and_token(token)
if Gem::Version.new(DeviseTokenAuth::VERSION) <= Gem::Version.new('1.1.0')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can create a method for this check, It is also used in client method on the base mutation

@mcelicalderon mcelicalderon merged commit 457c093 into master Sep 9, 2019
@mcelicalderon mcelicalderon deleted the check-reset-password-token branch September 9, 2019 16:59
@mcelicalderon mcelicalderon added the enhancement New feature or request label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants