Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added authorization for VariableReference fields #179

Merged
merged 1 commit into from
Dec 11, 2021
Merged

Added authorization for VariableReference fields #179

merged 1 commit into from
Dec 11, 2021

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Dec 11, 2021 •
edited
Loading

See #42 .Thanks @bogdancice

@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Dec 11, 2021
@sungam3r sungam3r mentioned this pull request Dec 11, 2021
Closed
@sungam3r sungam3r added the enhancement New feature or request label Dec 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2021 •
edited
Loading

Codecov Report

Merging #179 (9d6164d) into master (a193954) will increase coverage by 1.09%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   80.84%   81.93%   +1.09%     
==========================================
  Files           9        9              
  Lines         214      238      +24     
  Branches       32       36       +4     
==========================================
+ Hits          173      195      +22     
- Misses         32       33       +1     
- Partials        9       10       +1
Impacted Files Coverage Δ
...aphQL.Authorization/AuthorizationValidationRule.cs 94.93% <91.66%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a193954...9d6164d. Read the comment docs.

@sungam3r
Copy link
Member Author

@Shane32 I want to merge this ASAP and go on. I'll make suggestions from code review later if you have any.

@sungam3r sungam3r self-assigned this Dec 11, 2021
@sungam3r sungam3r added this to the 4.1 milestone Dec 11, 2021
@sungam3r sungam3r merged commit d0b411f into master Dec 11, 2021
@sungam3r sungam3r deleted the variables branch December 11, 2021 20:04
@sungam3r sungam3r added the bugfix Pull request that fixes a bug label Dec 11, 2021
@sungam3r sungam3r mentioned this pull request Dec 11, 2021
Closed
@Shane32
Copy link
Member

Shane32 commented Dec 11, 2021

Looks fine.

@sungam3r
Copy link
Member Author

Almost - #182 :)

@sungam3r sungam3r mentioned this pull request Dec 11, 2021
Open
@sungam3r sungam3r mentioned this pull request Dec 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shane32 Shane32 Awaiting requested review from Shane32

Assignees

@sungam3r sungam3r

Labels
bugfix Pull request that fixes a bug enhancement New feature or request test Pull request that adds new or changes existing tests
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sungam3r @codecov-commenter @Shane32