Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CamelCasePropertyNamesContractResolver causes incompatibility with Spec #59

Closed
deinok opened this issue Aug 27, 2018 · 0 comments · Fixed by #156
Closed

CamelCasePropertyNamesContractResolver causes incompatibility with Spec #59

deinok opened this issue Aug 27, 2018 · 0 comments · Fixed by #156
Assignees
Labels
bug Something isn't working
Milestone

Comments

@deinok
Copy link
Member

deinok commented Aug 27, 2018

ref: http://facebook.github.io/graphql/June2018/#sec-Names
ref: #58

However, using CamelCasePropertyNamesContractResolver on the entire
payload, also changes data field names to camelCase. Data fields (per
spec) can be any desired casing, so the current graphql-client library
won't work where data field names are not camel case.

So, the idea is force Query, OperationName and Variables to CamelCase without forcing the usage CamelCasePropertyNamesContractResolver that causes that the model of Variables to be forced to be CamelCase.

This needs further investigation, like:

  • Requests: It causes renaming of variables?
  • Response: Is the response also afected by this?
  • Serialization: Is there a way to fix this issues without depending on JSON implementation? Other Serialization formats cases

CC: @sys-dev

@deinok deinok added the bug Something isn't working label Aug 27, 2018
@deinok deinok added this to the v2.0.0 milestone Aug 27, 2018
@deinok deinok assigned deinok and unassigned deinok Aug 27, 2018
@rose-a rose-a linked a pull request Feb 6, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant