Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copyright #2358

Merged
merged 6 commits into from Mar 15, 2021
Merged

Update copyright #2358

merged 6 commits into from Mar 15, 2021

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Mar 5, 2021 •
edited

fixes #2342

@sungam3r sungam3r requested a review from Shane32 March 5, 2021 22:44
@github-actions github-actions bot added CI CI configuration issue or pull request performance Issue or pull request about performance problems test Pull request that adds new or changes existing tests labels Mar 5, 2021
@sungam3r sungam3r added code style Pull request that changes or applies code style rules and removed performance Issue or pull request about performance problems test Pull request that adds new or changes existing tests labels Mar 5, 2021
@Shane32
Copy link
Member

Shane32 commented Mar 5, 2021

If we update the copyright, the license file should be updated, and @joemcbride should approve it.

@github-actions github-actions bot added performance Issue or pull request about performance problems test Pull request that adds new or changes existing tests labels Mar 6, 2021
@sungam3r sungam3r requested a review from joemcbride March 6, 2021 14:17
@sungam3r
Copy link
Member Author

sungam3r commented Mar 6, 2021

Done.

@codecov-io
Copy link

Codecov Report

Merging #2358 (389160e) into develop (6e7c633) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2358      +/-   ##
===========================================
- Coverage    83.84%   83.82%   -0.02%     
===========================================
  Files          359      359              
  Lines        13640    13645       +5     
  Branches      2013     2013              
===========================================
+ Hits         11436    11438       +2     
- Misses        1642     1645       +3     
  Partials       562      562
Impacted Files Coverage Δ
src/GraphQL.MemoryCache/MemoryDocumentCache.cs 70.83% <0.00%> (-3.08%) ⬇️
src/GraphQL/Execution/ExecutionError.cs 86.79% <ø> (ø)
src/GraphQL/Introspection/__DirectiveArgument.cs 79.31% <0.00%> (-2.84%) ⬇️
src/GraphQL/Introspection/__DirectiveLocation.cs 100.00% <ø> (ø)
src/GraphQL/Introspection/__Schema.cs 98.66% <ø> (ø)
...phQL/Types/Directives/Built-in/IncludeDirective.cs 100.00% <ø> (ø)
...GraphQL/Types/Directives/Built-in/SkipDirective.cs 100.00% <ø> (ø)
src/GraphQL/Types/Scalars/DateGraphType.cs 76.92% <ø> (ø)
src/GraphQL/Types/Scalars/ScalarGraphType.cs 78.57% <ø> (ø)
...rectives/1+2. KnownDirectivesInAllowedLocations.cs 82.50% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e7c633...389160e. Read the comment docs.

Shane32
Shane32 approved these changes Mar 6, 2021
View reviewed changes
Copy link
Member

@Shane32 Shane32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joemcbride to also approve

@sungam3r sungam3r self-assigned this Mar 8, 2021
@Shane32
Copy link
Member

Shane32 commented Mar 12, 2021

@joemcbride Please approve when you have a chance.

@Shane32 Shane32 mentioned this pull request Mar 12, 2021
Closed
@sungam3r sungam3r removed performance Issue or pull request about performance problems test Pull request that adds new or changes existing tests labels Mar 12, 2021
@github-actions github-actions bot added performance Issue or pull request about performance problems test Pull request that adds new or changes existing tests labels Mar 12, 2021
@sungam3r sungam3r mentioned this pull request Mar 12, 2021
Merged
@sungam3r sungam3r removed performance Issue or pull request about performance problems test Pull request that adds new or changes existing tests labels Mar 12, 2021
@sungam3r sungam3r changed the title Update copyright + apply format Update copyright Mar 12, 2021
@sungam3r sungam3r merged commit f1c382d into develop Mar 15, 2021
@sungam3r sungam3r deleted the copyright branch March 15, 2021 17:56
@sungam3r sungam3r added this to the 4.0 milestone Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcbride joemcbride joemcbride approved these changes

@Shane32 Shane32 Shane32 approved these changes

Assignees

@sungam3r sungam3r

Labels
CI CI configuration issue or pull request code style Pull request that changes or applies code style rules
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sungam3r @Shane32 @codecov-io @joemcbride