User context docs update #2846
Merged
User context docs update #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Jan 7, 2022
| @@ -28,3 +28,20 @@ public class Query : ObjectGraphType | |||
| } | |||
| } | |||
| ``` | |||
|
|
|||
| If you need to access the User from the http request and populate this globally, you will need to add a User property to your custom `UserContext` class and modify your Startup configuration as follows: | |||
There was a problem hiding this comment.
populate this globally
What does globally mean?
There was a problem hiding this comment.
Thank you for catching this, adjusted the wording and added the other changes suggested.
sungam3r
reviewed
Jan 7, 2022
| @@ -28,3 +28,20 @@ public class Query : ObjectGraphType | |||
| } | |||
| } | |||
| ``` | |||
|
|
|||
| If you need to access the User from the http request and populate this globally, you will need to add a User property to your custom `UserContext` class and modify your Startup configuration as follows: | |||
There was a problem hiding this comment.
you will need to add a User property
or just
var context = new MyGraphQLUserContext(); // or even Dictionary<string, object?>();
context["User"] = user;
There was a problem hiding this comment.
So I would change wording from will need to to may.
sungam3r
reviewed
Jan 7, 2022
| } | ||
|
|
||
| services.AddGraphQL() | ||
| .AddUserContextBuilder(httpContext => new MyGraphQLUserContext(httpContext.User)); |
There was a problem hiding this comment.
There is no such method in this repo. It's method from server project. Worth to note explicitly.
sungam3r
approved these changes
Jan 12, 2022
|
@Shane32 Merge if OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.