-
-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't expose the disposed ServiceProvider instance #2847
Don't expose the disposed ServiceProvider instance #2847
Conversation
@Shane32 I think this is the change you suggested? I don't know if the issue should be moved from the server project and be linked with this PR? |
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@ganhammar yes thanks. It looks like the branch needs to be merged with the current 'master' branch so that we can let it run the tests and merge it. |
Yeah, sorry, I missed that I already had forked the repo a while back, so didn't pull latest changes. Fixed now! |
Codecov Report
@@ Coverage Diff @@
## master #2847 +/- ##
=======================================
Coverage 83.78% 83.78%
=======================================
Files 364 364
Lines 14978 14979 +1
Branches 2369 2369
=======================================
+ Hits 12549 12550 +1
Misses 1798 1798
Partials 631 631
Continue to review full report at Codecov.
|
@sungam3r look good? |
The
IServiceProvider
instance in theResolveEventStreamContext
has been disposed at the point where it gets exposed to the subscription resolver and any data loaded fields included in the GraphQL request. With this PR it is set tonull
instead of the disposed instance. See discussion here.I don't know if you would like to see tests for this change?