Fix the docs for ResolveScopedAsync #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Jan 10, 2022
| return db.Products.Where(x => x.CategoryId == context.Source.Id).ToListAsync(); | ||
| }); | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| In this case `context.RequestServices` will be an `IServiceProvider` in a newly created scope. |
There was a problem hiding this comment.
in a newly created
In general yes but it's up to implementation/caller side how to set context.RequestServices.
There was a problem hiding this comment.
@Shane32 If OK, merge when you want.
sungam3r
added
the
documentation
sungam3r
approved these changes
Jan 10, 2022
Shane32
approved these changes
Jan 10, 2022
|
Thanks @jeffw-wherethebitsroam ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for ResolveScopedAsync had incorrect code, so I had to go look at the source. This should now be correct.