Add InputType and OutputType attributes #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
test
|
Will review tomorrow. |
Shane32
force-pushed
the
add_inputtype
branch
from
676c682
to
b2ed8f7
Compare
sungam3r
reviewed
Jan 24, 2022
sungam3r
reviewed
Jan 24, 2022
| @@ -409,6 +417,12 @@ namespace GraphQL | |||
| public static T ToObject<T>(this System.Collections.Generic.IDictionary<string, object?> source) | |||
| where T : class { } | |||
| } | |||
| [System.AttributeUsage(System.AttributeTargets.Class | System.AttributeTargets.All)] | |||
There was a problem hiding this comment.
| System.AttributeTargets.All
Strange. The same with other attributes. I can not reproduce this output on my Windows machine.
sungam3r
approved these changes
Jan 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #2879 +/- ##
==========================================
- Coverage 83.78% 83.77% -0.02%
==========================================
Files 364 366 +2
Lines 14979 15017 +38
Branches 2369 2377 +8
==========================================
+ Hits 12550 12580 +30
- Misses 1798 1802 +4
- Partials 631 635 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates
InputTypeandOutputTypewhich are used for type mappings from theGraphQLMetadataattribute which is used for configuring an automatically-constructed graph type.The old properties remain as obsolete members.