Update middleware sample #2903
Update middleware sample #2903
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2903 +/- ##
=======================================
Coverage 83.77% 83.77%
=======================================
Files 366 366
Lines 15017 15017
Branches 2375 2375
=======================================
Hits 12580 12580
Misses 1802 1802
Partials 635 635 Continue to review full report at Codecov.
|
Shane32
added
the
documentation
| @@ -56,6 +56,7 @@ public void ConfigureServices(IServiceCollection services) | |||
| // add infrastructure stuff | |||
| services.AddHttpContextAccessor(); | |||
| services.AddLogging(builder => builder.AddConsole()); | |||
| services.AddSingleton<GraphQLMiddleware>(); | |||
There was a problem hiding this comment.
How did it work before? I mean app.UseMiddleware<GraphQLMiddleware>(); without services.Add?
There was a problem hiding this comment.
All services from ctor and Invoke are discovered and pulled by ASP.NET subsystem, right?
There was a problem hiding this comment.
Previously, yes that was correct, as it was "ASP.Net Core convention-based middleware". It was essentially a scoped/transient service, and DI services could be added to either the constructor or Invoke method.
With this change, the middleware is pulled from DI and it is called "ASP.Net Core factory-based middleware".
I think it's just a clearer sample.
There was a problem hiding this comment.
What about middleware from server repo?
There was a problem hiding this comment.
I'll review when I look at the serialization
ISchemavia DIIMiddlewareinterface