Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Then' data loader extension method for lists of data loader results. #3021

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Add 'Then' data loader extension method for lists of data loader results. #3021

merged 6 commits into from
Mar 22, 2022

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Mar 22, 2022

See need in issue #3019

@Shane32 Shane32 added this to the 4.8 milestone Mar 22, 2022
@Shane32 Shane32 self-assigned this Mar 22, 2022
@Shane32 Shane32 requested a review from sungam3r March 22, 2022 17:35
@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Mar 22, 2022
@Shane32 Shane32 added enhancement New feature or request and removed test Pull request that adds new or changes existing tests labels Mar 22, 2022
@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Mar 22, 2022
sungam3r
sungam3r approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@sungam3r sungam3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge as you see fit. I still do not use dataloaders.

Shane32 and others added 3 commits March 22, 2022 16:48
@Shane32 @sungam3r
Update src/GraphQL.DataLoader/DataLoaderExtensions.cs
a0aa97b 
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@Shane32 @sungam3r
Update src/GraphQL.DataLoader/DataLoaderExtensions.cs
4e6a76e 
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@Shane32 @sungam3r
Update src/GraphQL.DataLoader/DataLoaderExtensions.cs
91eec0f 
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@codecov-commenter
Copy link

Codecov Report

Merging #3021 (91eec0f) into master (10dd1d4) will decrease coverage by 0.15%.
The diff coverage is 31.11%.

@@            Coverage Diff             @@
##           master    #3021      +/-   ##
==========================================
- Coverage   83.77%   83.61%   -0.16%     
==========================================
  Files         366      366              
  Lines       15017    15062      +45     
  Branches     2375     2375              
==========================================
+ Hits        12580    12594      +14     
- Misses       1802     1833      +31     
  Partials      635      635
Impacted Files Coverage Δ
src/GraphQL.DataLoader/DataLoaderExtensions.cs 42.52% <31.11%> (-12.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8cc57...91eec0f. Read the comment docs.

@Shane32 Shane32 mentioned this pull request Mar 22, 2022
Closed
@Shane32 Shane32 merged commit 23b7943 into master Mar 22, 2022
@Shane32 Shane32 deleted the dataloader_then branch March 22, 2022 20:57
@sungam3r sungam3r added the data loader Relates to GraphQL data loaders label Mar 22, 2022
@Shane32 Shane32 mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungam3r sungam3r sungam3r approved these changes

Assignees

@Shane32 Shane32

Labels
data loader Relates to GraphQL data loaders enhancement New feature or request test Pull request that adds new or changes existing tests
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shane32 @codecov-commenter @sungam3r