Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization update #3077

Merged
merged 8 commits into from
Apr 9, 2022
Merged

Authorization update #3077

merged 8 commits into from
Apr 9, 2022

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Apr 9, 2022

Closes #3076

This also fixes the attribute so that it applies the metadata to query arguments or enum definitions also, if it is marked on those type of objects.

@Shane32 Shane32 requested a review from sungam3r April 9, 2022 21:35
@Shane32 Shane32 self-assigned this Apr 9, 2022
@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Apr 9, 2022
@Shane32 Shane32 added enhancement New feature or request new API New non breaking public APIs added and removed test Pull request that adds new or changes existing tests labels Apr 9, 2022
Copy link
Member

@sungam3r sungam3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only cosmetic changes suggestions.

Shane32 and others added 3 commits April 9, 2022 18:41
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@Shane32
Copy link
Member Author

Shane32 commented Apr 9, 2022

5.1.1 or 5.2.0 ?

@sungam3r
Copy link
Member

sungam3r commented Apr 9, 2022

5.1.1 since new APIs may be considered as a way to fix a bug

@Shane32
Copy link
Member Author

Shane32 commented Apr 9, 2022

5.1.1 since new APIs may be considered as a way to fix a bug

I agree

@codecov-commenter
Copy link

Codecov Report

Merging #3077 (d434838) into master (683f0ce) will increase coverage by 0.06%.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##           master    #3077      +/-   ##
==========================================
+ Coverage   84.31%   84.38%   +0.06%     
==========================================
  Files         360      360              
  Lines       15733    15830      +97     
  Branches     2556     2576      +20     
==========================================
+ Hits        13266    13358      +92     
- Misses       1857     1858       +1     
- Partials      610      614       +4     
Impacted Files Coverage Δ
...GraphQL/Authorization/GraphQLAuthorizeAttribute.cs 72.54% <70.21%> (+72.54%) ⬆️
...c/GraphQL/Authorization/AuthorizationExtensions.cs 70.42% <70.90%> (+70.42%) ⬆️
src/GraphQL.DataLoader/SimpleDataLoader.cs 86.36% <0.00%> (ø)
...rc/GraphQL/Utilities/Federation/FederatedSchema.cs 83.33% <0.00%> (ø)
src/GraphQL/Types/Schema.cs 79.90% <0.00%> (+0.91%) ⬆️
...rc/GraphQL/Utilities/XmlDocumentationExtensions.cs 57.33% <0.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b80908...d434838. Read the comment docs.

@Shane32 Shane32 merged commit f7146d7 into master Apr 9, 2022
@Shane32 Shane32 deleted the authorization_update branch April 9, 2022 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new API New non breaking public APIs added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no way to tell that authorization is required without a role or policy specified
3 participants