Fix error thrown for invalid operation name #3106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test
sungam3r
reviewed
Apr 27, 2022
| result.Errors[0].InnerException.ShouldBeOfType<InvalidOperationException>(); | ||
| result.Errors[0].InnerException.Message.ShouldBe($"Query does not contain operation '{operationName}'."); | ||
| result.Errors[0].ShouldBeOfType<InvalidOperationError>(); | ||
| result.Errors[0].Message.ShouldBe("Query does not contain operation '" + operationName + "'."); |
There was a problem hiding this comment.
Check InnerException for null ?
sungam3r
reviewed
Apr 27, 2022
| @@ -65,7 +64,7 @@ public static IServiceProvider CurrentServiceProvider | |||
| { | |||
| var method = _currentMethod.Value; | |||
| return method == null || !_diAdapters.TryGetValue(method, out var stack) || stack == null || stack.Count == 0 | |||
| ? throw new InvalidOperationError("Attempt to access IServiceProvider out of prepared DependencyInjection context.") | |||
sungam3r
reviewed
Apr 27, 2022
| @@ -147,7 +147,7 @@ public virtual async Task<ExecutionResult> ExecuteAsync(ExecutionOptions options | |||
|
|
|||
| if (operation == null) | |||
| { | |||
| throw new InvalidOperationException($"Query does not contain operation '{options.OperationName}'."); | |||
| throw new InvalidOperationError($"Query does not contain operation '{options.OperationName}'."); | |||
There was a problem hiding this comment.
Let's move metrics.SetOperationName(operation?.Name); after this check.
Codecov Report
@@ Coverage Diff @@
## master #3106 +/- ##
==========================================
+ Coverage 84.31% 84.34% +0.02%
==========================================
Files 362 362
Lines 15884 15884
Branches 2580 2579 -1
==========================================
+ Hits 13393 13397 +4
+ Misses 1875 1871 -4
Partials 616 616
Continue to review full report at Codecov.
|
sungam3r
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a request is executed with an operation name that is not listed in the document, a "client" (validation) error should be returned to the caller with friendly description, rather than a "server" error being thrown which triggers the unhandled exception delegate and returns a masked error to the caller.