Optimize InstrumentFieldsMiddleware when metrics are disabled #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
commented
May 11, 2022
| @@ -6,7 +6,14 @@ namespace GraphQL.Instrumentation | |||
| public class InstrumentFieldsMiddleware : IFieldMiddleware | |||
| { | |||
| /// <inheritdoc/> | |||
| public async ValueTask<object?> ResolveAsync(IResolveFieldContext context, FieldMiddlewareDelegate next) | |||
| public ValueTask<object?> ResolveAsync(IResolveFieldContext context, FieldMiddlewareDelegate next) | |||
There was a problem hiding this comment.
Sync when metrics are disabled.
Shane32
reviewed
May 11, 2022
Co-authored-by: Shane Krueger <shane@acdmail.com>
Shane32
approved these changes
May 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #3130 +/- ##
==========================================
- Coverage 84.38% 84.36% -0.02%
==========================================
Files 362 362
Lines 15900 15905 +5
Branches 2583 2584 +1
==========================================
+ Hits 13417 13419 +2
- Misses 1867 1868 +1
- Partials 616 618 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.