Fix nested complexity fragment sorting #3209
Conversation
github-actions
bot
added
the
test
sungam3r
changed the title
|
5.4 ? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| foreach (var item in dependencies) | ||
| { | ||
| if (item.Value == null) | ||
| return item.Key; | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
|
WOW, works fine locally, failed on CI due to |
| foreach (var item in dependencies) // no deconstruct syntax for netstandard2.0 | ||
| { | ||
| if (item.Value?.Remove(independentFragment) == true && item.Value.Count == 0) | ||
| fragsToNull.Add(item.Key); | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
Codecov Report
@@ Coverage Diff @@
## master #3209 +/- ##
==========================================
+ Coverage 84.44% 84.46% +0.02%
==========================================
Files 371 370 -1
Lines 16042 16051 +9
Branches 2602 2604 +2
==========================================
+ Hits 13547 13558 +11
+ Misses 1873 1872 -1
+ Partials 622 621 -1
Continue to review full report at Codecov.
|
| return item.Key; | ||
| } | ||
|
|
||
| throw new InvalidOperationException("Fragments dependency cycle detected!"); |
I think it might be due to different frameworks. |
|
Looks good to me. I'll merge and make a release. |
|
This is the only PR merged since 5.3.1 so this will be 5.3.2 as it is a bugfix |
Added failing test
Demonstrating that by swapping the order of two fragments, the test either passes or fails
[UPDATE]
Fixed by second commit.
5 4 2 1 3 - order before
5 3 2 4 1 - order after
Now should work for all cases.