-
-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix package versioning #3231
Merged
Merged
Fix package versioning #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sungam3r I'd like to merge this and release 5.3.3 |
sungam3r
reviewed
Jul 19, 2022
sungam3r
approved these changes
Jul 19, 2022
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
Codecov Report
@@ Coverage Diff @@
## master #3231 +/- ##
==========================================
- Coverage 84.46% 84.45% -0.02%
==========================================
Files 370 371 +1
Lines 16051 16051
Branches 2604 2605 +1
==========================================
- Hits 13558 13556 -2
- Misses 1872 1873 +1
- Partials 621 622 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, for example, restricts GraphQL.DataLoader to use only GraphQL 5.x versions. Specifically, the matching version that was published, and any version up to but excluding the next major version number. This will prevent GraphQL.DataLoader 5.3.3 from being compatible with GraphQL 7.0.0, and indirectly prevents #3229 from happening in the future. A similar change should be made in the server repo.
See:
dotnet pack
to support semver NuGet/Home#5556