Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package versioning #3231

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Fix package versioning #3231

merged 3 commits into from
Jul 19, 2022

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Jul 15, 2022

This, for example, restricts GraphQL.DataLoader to use only GraphQL 5.x versions. Specifically, the matching version that was published, and any version up to but excluding the next major version number. This will prevent GraphQL.DataLoader 5.3.3 from being compatible with GraphQL 7.0.0, and indirectly prevents #3229 from happening in the future. A similar change should be made in the server repo.

See:

@Shane32 Shane32 changed the title WIP package versioning [WIP] Fix package versioning Jul 15, 2022
@github-actions github-actions bot added the CI CI configuration issue or pull request label Jul 15, 2022
@Shane32
Copy link
Member Author

Shane32 commented Jul 15, 2022

Seems to work properly

image

@Shane32 Shane32 changed the title [WIP] Fix package versioning Fix package versioning Jul 15, 2022
@Shane32 Shane32 self-assigned this Jul 15, 2022
@Shane32 Shane32 added this to the 5.4 milestone Jul 15, 2022
@Shane32 Shane32 requested a review from sungam3r July 18, 2022 19:32
@Shane32
Copy link
Member Author

Shane32 commented Jul 18, 2022

@sungam3r I'd like to merge this and release 5.3.3

@sungam3r sungam3r added the dependencies Pull request that updates a dependency file label Jul 19, 2022
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@codecov-commenter
Copy link

Codecov Report

Merging #3231 (d509fd4) into master (87d7a5e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3231      +/-   ##
==========================================
- Coverage   84.46%   84.45%   -0.02%     
==========================================
  Files         370      371       +1     
  Lines       16051    16051              
  Branches     2604     2605       +1     
==========================================
- Hits        13558    13556       -2     
- Misses       1872     1873       +1     
- Partials      621      622       +1     
Impacted Files Coverage Δ
...dationContext.GetRecursivelyReferencedFragments.cs 98.30% <0.00%> (-1.70%) ⬇️
src/GraphQL/Resolvers/FuncFieldResolver.cs 88.88% <0.00%> (-1.24%) ⬇️
src/GraphQL/Resolvers/SourceFieldResolver.cs 100.00% <0.00%> (ø)
...GraphQL/Execution/SubscriptionExecutionStrategy.cs 93.37% <0.00%> (+0.03%) ⬆️
src/GraphQL/Execution/ExecutionStrategy.cs 85.23% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d7a5e...d509fd4. Read the comment docs.

@Shane32 Shane32 merged commit 275e7f5 into master Jul 19, 2022
@Shane32 Shane32 deleted the versioning branch July 19, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI configuration issue or pull request dependencies Pull request that updates a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants