Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root types must all be different types if provided #3590

Merged
merged 2 commits into from Apr 15, 2023
Merged

Conversation

sungam3r
Copy link
Member

No description provided.

@sungam3r sungam3r added the spec compliance The change is intended to solve the problem of inconsistency with the official GraphQL specification label Apr 15, 2023
@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Apr 15, 2023
@sungam3r sungam3r self-assigned this Apr 15, 2023
@sungam3r sungam3r requested a review from Shane32 April 15, 2023 06:55
var n1 = schema.Query?.Name;
var n2 = schema.Mutation?.Name;
var n3 = schema.Subscription?.Name;
if (n1 == n2 && n1 != null || n1 == n3 && n1 != null || n2 == n3 && n2 != null)

Check notice

Code scanning / CodeQL

Complex condition Note

Complex condition: too many logical operations in this expression.
@codecov-commenter
Copy link

Codecov Report

Merging #3590 (d7ac9d1) into master (57c0e24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master    #3590   +/-   ##
=======================================
  Coverage   83.89%   83.89%           
=======================================
  Files         381      381           
  Lines       16884    16891    +7     
  Branches     2710     2714    +4     
=======================================
+ Hits        14164    14171    +7     
  Misses       2073     2073           
  Partials      647      647           
Impacted Files Coverage Δ
...phQL/Utilities/Visitors/SchemaValidationVisitor.cs 73.26% <100.00%> (+1.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sungam3r sungam3r merged commit 0d53acb into master Apr 15, 2023
8 checks passed
@sungam3r sungam3r deleted the root-types branch April 15, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec compliance The change is intended to solve the problem of inconsistency with the official GraphQL specification test Pull request that adds new or changes existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants