Make SchemaPrinter more flexible #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine to merge this one but note that all |
sungam3r
approved these changes
Apr 27, 2023
|
You need to update api approval file. Just run tests locally. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #3618 +/- ##
==========================================
- Coverage 83.93% 83.92% -0.02%
==========================================
Files 381 381
Lines 16888 16888
Branches 2717 2717
==========================================
- Hits 14175 14173 -2
- Misses 2068 2069 +1
- Partials 645 646 +1
|
|
@sungam3r now everything should be ready |
|
@Shane32 merge if OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow more methods to be overrided.
This is do to enable custom implementations of the SchemaPrinter the support custom print implementations for Scalars, InputObjects, Unions, Arguments and Enumerations.