Add SchemaExporter, schema.ToAST(), and schema.Print() #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Shane32
commented
Jun 26, 2023
Comment on lines
+237
to
+290
| if (graphType.HasExtensionAstTypes() && graphType.GetAstType<ASTNode>() == null) | ||
| { | ||
| return node switch | ||
| { | ||
| GraphQLObjectTypeDefinition otd => new GraphQLObjectTypeExtension(otd.Name) | ||
| { | ||
| Interfaces = otd.Interfaces, | ||
| Fields = otd.Fields, | ||
| Directives = otd.Directives, | ||
| Comments = otd.Comments, | ||
| }, | ||
| GraphQLInterfaceTypeDefinition itd => new GraphQLInterfaceTypeExtension(itd.Name) | ||
| { | ||
| Interfaces = itd.Interfaces, | ||
| Fields = itd.Fields, | ||
| Directives = itd.Directives, | ||
| Comments = itd.Comments, | ||
| }, | ||
| GraphQLUnionTypeDefinition utd => new GraphQLUnionTypeExtension(utd.Name) | ||
| { | ||
| Types = utd.Types, | ||
| Directives = utd.Directives, | ||
| Comments = utd.Comments, | ||
| }, | ||
| GraphQLScalarTypeDefinition std => new GraphQLScalarTypeExtension(std.Name) | ||
| { | ||
| Directives = std.Directives, | ||
| Comments = std.Comments, | ||
| }, | ||
| GraphQLEnumTypeDefinition etd => new GraphQLEnumTypeExtension(etd.Name) | ||
| { | ||
| Values = etd.Values, | ||
| Directives = etd.Directives, | ||
| Comments = etd.Comments, | ||
| }, | ||
| GraphQLInputObjectTypeDefinition iotd => new GraphQLInputObjectTypeExtension(iotd.Name) | ||
| { | ||
| Fields = iotd.Fields, | ||
| Directives = iotd.Directives, | ||
| Comments = iotd.Comments, | ||
| }, | ||
| GraphQLSchemaDefinition sd => new GraphQLSchemaExtension | ||
| { | ||
| OperationTypes = sd.OperationTypes, | ||
| Directives = sd.Directives, | ||
| Comments = sd.Comments, | ||
| }, | ||
| _ => throw new InvalidOperationException($"Invalid node type of '{node.GetType().GetFriendlyName()}'.") | ||
| }; | ||
| } | ||
| else | ||
| { | ||
| return node; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Shane32
changed the title
Comment on lines
+28
to
+38
| if (directive.Name.Value == "deprecated") | ||
| { | ||
| if (directive.Arguments != null) | ||
| { | ||
| directive.Arguments.Items.RemoveAll(a => a.Name.Value == "reason"); | ||
| if (directive.Arguments.Items.Count == 0) | ||
| { | ||
| directive.Arguments = null; | ||
| } | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Nested 'if' statements can be combined Note
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3649 +/- ##
==========================================
+ Coverage 84.01% 84.03% +0.02%
==========================================
Files 394 399 +5
Lines 17099 17593 +494
Branches 2736 2799 +63
==========================================
+ Hits 14366 14785 +419
- Misses 2084 2145 +61
- Partials 649 663 +14
|
Shane32
changed the title
This was referenced Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds capability to 'export' a configured GraphQL.NET schema into an AST document suitable for printing by GraphQL.NET Parser into SDL. The new
SchemaExporterclass currently has no options and will export the entire schema. The GraphQL.NET Parser library will then handle sorting the schema and/or printing it, as desired. An extension method has been added toISchemato easily export and print the schema in one step. In order to support theIncludeDeprecationReasonsandIncludeDescriptionsproperties of the oldSchemaPrinter, AST visitors have been added to remove the undesired information.Those properties have a default value of
true(previouslyfalse). The property for sorting preferences defaults to unsorted. All in, this should remove the need for theSchemaPrinterandFederatedSchemaPrinterclasses.Waiting on:
Replaces:
Closes: