Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom validation rule for denying introspection queries #3695

Merged
merged 2 commits into from Sep 17, 2023

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Aug 22, 2023

This seems to be an often-asked question, so this PR adds a validation rule for denying introspection queries to the codebase.

@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Aug 22, 2023
@Shane32 Shane32 added this to the 7.6 milestone Aug 22, 2023
@Shane32 Shane32 added enhancement New feature or request and removed test Pull request that adds new or changes existing tests labels Aug 22, 2023
@Shane32 Shane32 self-assigned this Aug 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3695 (b44196e) into master (8c9c147) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3695      +/-   ##
==========================================
+ Coverage   84.04%   84.05%   +0.01%     
==========================================
  Files         399      401       +2     
  Lines       17593    17607      +14     
  Branches     2799     2800       +1     
==========================================
+ Hits        14786    14800      +14     
  Misses       2145     2145              
  Partials      662      662              
Files Changed Coverage Δ
...L/Validation/Errors.Custom/NoIntrospectionError.cs 100.00% <100.00%> (ø)
...tion/Rules.Custom/NoIntrospectionValidationRule.cs 100.00% <100.00%> (ø)

@Shane32 Shane32 merged commit 4792dca into master Sep 17, 2023
10 checks passed
@Shane32 Shane32 deleted the add_nointrospection_rule branch September 17, 2023 03:55
@Shane32 Shane32 modified the milestones: 7.6, 7.7 Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants