Fix document caching and add tests #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test
Shane32
added
bugfix
|
@gao-artur are we ready to release 7.7 after this PR ? if so, i'll issue the release after merging. |
gao-artur
approved these changes
Dec 13, 2023
|
@Shane32, yes, we are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryDocumentCache was essentially useless, not passing on cached documents to the document executer, nor storing parsed documents and saving them in the cache. Broke during 7.0 transition to
IConfigureExecutionin #3272 . Added tests to ensure the cache's ExecuteAsync method works correctly in the future.