Schema builder fixes; add schema validation of subscription fields #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
commented
Jan 1, 2024
| @@ -111,14 +111,19 @@ private Schema BuildSchemaFrom(GraphQLDocument document) | |||
|
|
|||
| var directives = new List<Directive>(); | |||
|
|
|||
| // process the schema definition first | |||
| foreach (var def in document.Definitions) | |||
| { | |||
| if (def is GraphQLSchemaDefinition schemaDef) | |||
| { | |||
| _schemaDef = schemaDef; | |||
There was a problem hiding this comment.
_schemaDef must be set first or subscription resolvers don't get set properly. Who knows; maybe it affects more stuff.
Shane32
commented
Jan 1, 2024
| @@ -74,7 +74,7 @@ public void Include(Type type) | |||
| /// </summary> | |||
| public void Include(string name, Type type) | |||
| { | |||
| _typeConfigurations[name].Type = type; | |||
| For(name).Type = type; | |||
There was a problem hiding this comment.
ForAll only triggers when using For, but seems to clearly indicate that it should operate on all types. So I've changed Include to call For and thereby execute any configured ForAll code.
Shane32
changed the title
gao-artur
reviewed
Jan 1, 2024
Shane32
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3867 +/- ##
==========================================
- Coverage 84.66% 84.66% -0.01%
==========================================
Files 419 419
Lines 19333 19344 +11
Branches 3033 3037 +4
==========================================
+ Hits 16369 16377 +8
- Misses 2251 2253 +2
- Partials 713 714 +1 ☔ View full report in Codecov by Sentry. |
gao-artur
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3580
Adds schema validation to ensure that
StreamResolveris set for fields of root subscription types. This is a non-breaking change because without the validation, attempting to resolve these fields would fail at runtime.Trying to write a fix for #3580 I found two bugs in the schema-first SchemaBuilder (as far as I can tell).
Includedoes not include configurations viaForAllschemadefinition is listed after the subscription definition