Add DirectiveAttribute #3886
Add DirectiveAttribute #3886
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3886 +/- ##
==========================================
- Coverage 84.36% 84.18% -0.18%
==========================================
Files 420 421 +1
Lines 19470 19514 +44
Branches 3041 3043 +2
==========================================
+ Hits 16426 16428 +2
- Misses 2329 2372 +43
+ Partials 715 714 -1 ☔ View full report in Codecov by Sentry. |
| /// The <paramref name="argsAndValues"/> parameter must contain an even number of elements, where | ||
| /// the first element of each pair is the argument name and the second element is the argument value. | ||
| /// </remarks> | ||
| public DirectiveAttribute(string name, params object[] argsAndValues) |
There was a problem hiding this comment.
Is it worth adding an analyzer to ensure an even number of elements and the argument names are strings?
There was a problem hiding this comment.
Probably pretty low on the priority list. Sure that would be nice, and it could check that the first element of each pair was a string too. Keep people from doing stuff like [Directive("maxlength", 5)] when they meant to do [Directive("maxlength", "value", 5)]
Samples and tests in PR #3885
This new directive mirrors the existing MetadataAttribute which allows adding arbitrary metadata to type-first schemas.