Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom casing on inferred enum graph types #841

Conversation

freakingawesome
Copy link
Contributor

The default behavior of EnumGraphType converts the enum values to uppercase. This commit allows you to specify a custom behavior for changing case.

@joemcbride
Copy link
Member

This appears to have a valid failing test, can you take a look?

@freakingawesome
Copy link
Contributor Author

Yea, that's an odd failure. I haven't been able to reproduce it locally or make any sense of how my minor change could have caused the failure. I'm merging latest from master to trigger another build and will see what happens.

@freakingawesome
Copy link
Contributor Author

Another failed build - but this time it's failing on what looks like nuget trying to create a an invalid version string.

@freakingawesome
Copy link
Contributor Author

I think that latest nuget failure is caused by the / character in my branch name. I could close this and open up a new PR against a more appropriate branch name to see if that fixes it, if you think that would be beneficial.

@joemcbride
Copy link
Member

No that's fine, that is a known issue in the build script currently.

@joemcbride joemcbride merged commit a06cf1d into graphql-dotnet:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants