Support for descriptions

[pekkah]

So 4.0 added support for comments but it seems that comments should be ignored by the parser. Descriptions are what the spec uses for documentation. More here graphql/graphql-js#927 and here https://graphql.github.io/graphql-spec/June2018/#sec-Descriptions

[sungam3r]

Relates to graphql/graphql-spec#420

[pekkah]

I have since implemented a new parser which handles the descriptions correctly so this is not an issue for me anymore. Please reopen if you want to track this as a feature request.

[sungam3r]

Yes, I want to track this issue.

[prowe]

We are also running into this issue, what would the steps be in adding support for this?

[sungam3r]

Just as usual - PR, review, merge, publish, update dependent projects.

[sungam3r]

Also see #124 :

var schema = Schema.For(@"""Root type for all queries""
type Query {
  ""Documentation for the field""
  name: String
}");

[Shane32]

@sungam3r At a minimum, we should ignore description fields, even if for a later version we actually parse them. I would say this should be done for 4.0 if we have the time. (Ok to release 4.0 now though; this can always just be an updated version of the parser engine, and we can release 4.0.1 to use the new parser.)

[sungam3r]

Support for descriptions was added in #132