add support for comments on fragments and variables #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to #33 and to me looks wrong |
|
#1617 ? |
sungam3r
reviewed
Mar 18, 2020
sungam3r
reviewed
Mar 18, 2020
|
@pekkah Descriptions is another story. Nothing wrong with this PR. To support descriptions much more changes are needed. Someday we will do it. |
sungam3r
approved these changes
Mar 18, 2020
Merged
|
@sungam3r Thank you for your quick review and acceptance :-) |
|
I have no rights to publish on NuGet. @joemcbride has. You can get the latest version from myget feed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sungam3r I have fixed the issues for comment on fragments (spread and inline) and variables.
It should allow to uncomment the corresponding 3 tests in #1617