Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No allocations on GraphQLSyntaxErrorException #23

Merged
merged 2 commits into from
Mar 20, 2019
Merged

No allocations on GraphQLSyntaxErrorException #23

merged 2 commits into from
Mar 20, 2019

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Mar 8, 2019

Now the test case returns control instantly. There are no more delays for allocation of garbage strings.

BenchmarkDotNet=v0.10.14, OS=Windows 10.0.17134
Intel Core i5-6200U CPU 2.30GHz (Skylake), 1 CPU, 4 logical and 2 physical cores
Frequency=2343747 Hz, Resolution=426.6672 ns, Timer=TSC
  [Host]     : .NET Framework 4.7.1 (CLR 4.0.30319.42000), 64bit RyuJIT-v4.7.3324.0
  DefaultJob : .NET Framework 4.7.1 (CLR 4.0.30319.42000), 64bit RyuJIT-v4.7.3324.0
Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
ParseBinaryFile 3,537.87 us 70.489 us 201.110 us 812.5000 750.0000 730.4688 3312.19 KB

@sungam3r sungam3r changed the title fixes #22 No allocations on GraphQLSyntaxErrorException Mar 8, 2019
@sungam3r
Copy link
Member Author

sungam3r commented Mar 8, 2019

Fixes #22

@sungam3r sungam3r mentioned this pull request Mar 20, 2019
Merged
@joemcbride
Copy link
Member

Looks like this has conflicts with the other PR I just merged. Mind fixing those and I can get it merged?

@sungam3r
Merge branch 'master' of https://github.com/graphql-dotnet/parser int…
312d784 
…o feature/perf

# Conflicts:
#	src/GraphQLParser/ParserContext.cs
@joemcbride joemcbride merged commit 9b8937d into graphql-dotnet:master Mar 20, 2019
@sungam3r sungam3r deleted the feature/perf branch March 20, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sungam3r @joemcbride