Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Extend focused nodes #590

Closed
wants to merge 9 commits into from
Closed

Conversation

AnnaLysiuk
Copy link
Collaborator

@AnnaLysiuk AnnaLysiuk requested a review from aexol January 17, 2024 14:09
@AnnaLysiuk AnnaLysiuk self-assigned this Jan 17, 2024
setTransform(transformTo.x, transformTo.y, s, 200, "easeOut");
setTimeout(() => {
setTransform(transformTo.x, transformTo.y, s, 200, "easeOut");
}, 250);
Copy link
Collaborator Author

@AnnaLysiuk AnnaLysiuk Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To mi sie niezbyt podoba, ale nie chciało mi transformowac do dodanego noda bez tego. Może dlatego że setSelectedNode też jest z timeoutem

Troche spowalnia to przesuwanie ale moim zdaniem bez uszczerbku na UI. Możemy o tym podyskutować ofc jak masz pomysl dlaczego tak jest. Bo to jakby chce dodac napierw node ktory nie jest aktualnie wyrenderowany a potem oznaczyc go selected

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nie no uszczerbek jest i to bardzo duży, pomyślimy co z tym zrobić

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok wywaliłam oba timeouty na pierwszy rzut oka działa ok, ale nie wiem po so on był w tym setSelectedId może ty pamiętasz co trzeba potestowac żeby sprawdzic czy nic się ie popsuło

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

przerzucam na wip jeszcze będę testować

@AnnaLysiuk AnnaLysiuk changed the title Extend focused nodes [WIP] Extend focused nodes Jan 18, 2024
@AnnaLysiuk AnnaLysiuk closed this Jan 31, 2024
@AnnaLysiuk AnnaLysiuk deleted the extend-focused-nodes branch January 31, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants