-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Extend focused nodes #590
Conversation
setTransform(transformTo.x, transformTo.y, s, 200, "easeOut"); | ||
setTimeout(() => { | ||
setTransform(transformTo.x, transformTo.y, s, 200, "easeOut"); | ||
}, 250); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To mi sie niezbyt podoba, ale nie chciało mi transformowac do dodanego noda bez tego. Może dlatego że setSelectedNode też jest z timeoutem
Troche spowalnia to przesuwanie ale moim zdaniem bez uszczerbku na UI. Możemy o tym podyskutować ofc jak masz pomysl dlaczego tak jest. Bo to jakby chce dodac napierw node ktory nie jest aktualnie wyrenderowany a potem oznaczyc go selected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nie no uszczerbek jest i to bardzo duży, pomyślimy co z tym zrobić
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok wywaliłam oba timeouty na pierwszy rzut oka działa ok, ale nie wiem po so on był w tym setSelectedId może ty pamiętasz co trzeba potestowac żeby sprawdzic czy nic się ie popsuło
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
przerzucam na wip jeszcze będę testować
https://extend-focused-nodes.graphql-editor-dev.pages.dev/?a=withSchema