distinguish no schema and tree build failure situations #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chodzi o ten problem
https://3.basecamp.com/5657330/buckets/33764929/todos/7397552495
Generalnie mamy dwa stepy przy budowaniu tree, najpierw jest generateTree potem validate. Jesli jest problem na validate to issue nie wystepuje na cloud wersji, czyli tree sie buduje nody sie wyswietlają natomiast jesli zastartujemy projekt ktory bedzie mial error typu
Unexpected <EOF>to w ogóle drzewo sie nie zbuduje i pokaze nam widok jak przy braku schemy z opcja stworzenia nowego noda itdSugeruje rozgraniczenie tych widoków znaczy on teraz pokazuje no schema jak tree.nodes są puste proponuje sprawdzać jeszcze scheme w tym widoku i jak jest schema ale nie da się zbudować tree będzie to tak wyglądalo
Jak są inne propozycje dawaj znaka