-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Handling? #115
Comments
Is this not already possible with the current state of the library? I'm not sure if this feature existed at the time this issue was posted but as it stands a resolve function now has a return type of Should this issue be closed? |
I am bit worried about not much activities on pending pull requests and issues. @chris-ramon and @sogko poured ton of effort initially and wonder how they feel about the project now. May be it is a good idea to include @bbuck @pyros2097 and other frequent users of this library to have commit rights? |
Actually even I've stopped using this library and gone back to using graphql-js and the other go-graphql library and am in the process of creating one for rust(just for fun). |
Storing |
Graphql go right now swallows all errors and returns them back to the user. Sometimes we get database errors like
SQL State: conflicting foreign key
and this error goes back to the user. This is related to graphql/graphql-js#28.We should add some add some ErrorHandling logic to prevent some of these errors for going back and also returning them back to the application so that it can know what to do with it (like log, mail).
The graphql scala https://github.com/sangria-graphql/sangria version have done a really good way of handling it here http://sangria-graphql.org/learn/ Maybe we should try their approach?
The text was updated successfully, but these errors were encountered: