Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NullValue to allow sending null in a value literal #460

Closed
wants to merge 1 commit into from

Conversation

clery
Copy link

@clery clery commented Mar 10, 2019

I noticed null was not a valid value to return anywhere in a ParseLiteral, so I took a look at the way the parsing was done with graphql-js and tried reimplementing their NullValue.

There may be other stuff to do, for example fixing #457 to allow sending null to any scalar type as an argument.

Feel free to tell me if anything looks bad or whatever 🙂

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.17% when pulling 1967934 on clery:master into c13c47a on graphql-go:master.

@clery
Copy link
Author

clery commented Mar 15, 2019

Just noticed that there already is a pull request about this #401

@clery clery closed this Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants