Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Object.Definition() #465

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement Object.Definition() #465

wants to merge 2 commits into from

Conversation

KevinShiCA
Copy link

The Object.Definition() method was stubbed to return an empty string. This PR makes it return gt.PrivateDescription.

@coveralls
Copy link

coveralls commented Mar 23, 2019

Coverage Status

Coverage increased (+0.05%) to 92.399% when pulling 1119e3c on KevinShiCA:master into bed865f on graphql-go:master.

@siliconbrain
Copy link

I just ran into this too, wrote the same patch, then found this PR before opening my own. Please, merge this! It's a one liner, the author even wrote a test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants