Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for custom marshalers through the encoding.TextMarshaler interface #475

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Fontinalis
Copy link
Collaborator

This PR adds a check to each built-in coerce function, so if the value implements the encoding.TextMarshaler interface, it'll be marshaled and converted from that, so custom types, like some nullable type from github.com/guregu/null would work correctly.

Closes #471

@Fontinalis
Copy link
Collaborator Author

Fontinalis commented Apr 15, 2019 via email

@limoli
Copy link

limoli commented Oct 11, 2019

When are you going to merge this important feature into master?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 92.288% when pulling b7c3a1a on custom-marshaler into 02caa89 on master.

@Fontinalis
Copy link
Collaborator Author

@chris-ramon Can you review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad JSON marshaling for custom Marshaler
3 participants