Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tag with the formatting error changes? #63

Closed
tapocol opened this issue Dec 20, 2018 · 3 comments
Closed

New tag with the formatting error changes? #63

tapocol opened this issue Dec 20, 2018 · 3 comments

Comments

@tapocol
Copy link

tapocol commented Dec 20, 2018

The graphql library has been tagged with v0.7.7 with the formatting error changes: https://github.com/graphql-go/graphql/tree/v0.7.7

Will this repo be getting a tagged version soon that correlates to that tag on the graphql repo?

@chris-ramon
Copy link
Member

Hi @tapocol! thanks for the friendly reminder 👍 , I've just released graphql-go/handler v0.2.3 which targets latest graphql-go/graphql v0.7.7

@tapocol
Copy link
Author

tapocol commented Jan 2, 2019

It looks like there is a mixup. https://github.com/graphql-go/graphql/commits/v0.7.7 does not include a commit for "consolidates original error to allow custom format error". Yet, handler tag https://github.com/graphql-go/handler/commits/v0.2.3 does include a commit for "handler: consolidate FormatErrorFn"

It seems like these tags are incompatible. as FormatErrorFn in the handler package seems to just get nil for the error from the graphql/gqlerrors package.

@tapocol
Copy link
Author

tapocol commented Jan 2, 2019

It seems like these tags are incompatible. as FormatErrorFn in the handler package seems to just get nil for the error from the graphql/gqlerrors package.

Oh, this looks like it is nil because now instead of the context of gqlerrors.FormattedError in the argument, that argument is stripped to the result of OriginalError() call to the FormattedError. Which in the case of my testing originalError on FormattedError was not being set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants