PLEASE REVIEW: Add error return value to resolvers (fixes for recent graphql-go change) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge). This corrects the function signatures for all graphql.ResolverFn handlers so that the graphql-go/handler package pull-request can pass tests. However, I'm not too familiar with this code and I'm not confident that my changes are semantically correct -- some of the handlers look like they may want to return errors rather than returning nil. In a few cases (e.g. plural.go), I went ahead and added some error returns, but these really should be audited and tested.
|
Thanks for this PR contribution! I'll close this since its similar to #11 Regarding the appropriate error messages, we might go over it in a separate PR. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the function signatures for all graphql.ResolverFn handlers
so that the graphql-go/handler package pull-request can pass tests.
However, I'm not too familiar with this code and I'm not confident that my
changes are semantically correct -- some of the handlers look like they
may want to return errors rather than returning nil. In a few cases
(e.g. plural.go), I went ahead and added some error returns, but these
really should be audited and tested.