illegal global id should yield illegal argument exception

graphql-java · Oct 26, 2016 · 662ec10 · 662ec10
1 parent 7b87d54
commit 662ec10
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/main/java/graphql/relay/Relay.java b/src/main/java/graphql/relay/Relay.java
@@ -212,6 +212,9 @@ public String toGlobalId(String type, String id) {
 
     public ResolvedGlobalId fromGlobalId(String globalId) {
         String[] split = Base64.fromBase64(globalId).split(":", 2);
+        if (split.length != 2) {
+            throw new IllegalArgumentException(String.format("expecting a valid global id, got %s", globalId));
+        }
         return new ResolvedGlobalId(split[0], split[1]);
     }
 }