Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match new spec for non-null attributes with default values #1046

Closed
filipncs opened this issue May 14, 2018 · 2 comments
Closed

Match new spec for non-null attributes with default values #1046

filipncs opened this issue May 14, 2018 · 2 comments
Milestone

Comments

@filipncs
Copy link
Contributor

The spec was recently changed to clarify what to do with non-null attributes with default values:
graphql/graphql-spec#418

I've added a PR to illustrate how we don't live up to the new spec:
#1045

Thoughts? I think it should be a fairly simple fix for this case, but maybe this would cause other problems?

Note that this was a specific issue I ran into with trying to use the new spec, there could easily be other issues that should be fixed.

@filipncs
Copy link
Contributor Author

filipncs commented May 14, 2018

I added a commit to the PR that performs the necessary change. Doesn't seem to obviously break anything else.

@bbakerman
Copy link
Member

Thanks for reporting. I will look at the PR and comment there.

For the record there was a LOT of angst about defaulting null values in the new spec. A lot!

@bbakerman bbakerman added this to the 9.0 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants