Multi source reader for parsing graphql Documents #1411
Conversation
… text comes from and map back to those places relative to each part. The idea is that multiple files could feed a parsing document and errors reported in terms of those files not the logical place Of course it works for a single string and presents 1 source and nothing will be relative
| @@ -139,7 +139,7 @@ class GraphQLTest extends Specification { | |||
| then: | |||
| errors.size() == 1 | |||
| errors[0].errorType == ErrorType.InvalidSyntax | |||
| errors[0].locations == [new SourceLocation(1, 8)] | |||
| errors[0].locations == [new SourceLocation(0, 8)] | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
{ hello } is now considered as 0 based not 1's based
There was a problem hiding this comment.
why did you change the index? the spec says
where each location is a map with the keys line and column, both positive numbers starting from 1 which describe the beginning of an associated syntax element.
There was a problem hiding this comment.
Ahh I did not know the spec says that - I guess we need to add one,
Ones based index are weird right?? It goes against 50 years of computing theory! ;)
| return new Builder(); | ||
| } | ||
|
|
||
| public static class Builder { |
There was a problem hiding this comment.
you want a private constructor here maybe
| @@ -139,7 +139,7 @@ class GraphQLTest extends Specification { | |||
| then: | |||
| errors.size() == 1 | |||
| errors[0].errorType == ErrorType.InvalidSyntax | |||
| errors[0].locations == [new SourceLocation(1, 8)] | |||
| errors[0].locations == [new SourceLocation(0, 8)] | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
why did you change the index? the spec says
where each location is a map with the keys line and column, both positive numbers starting from 1 which describe the beginning of an associated syntax element.
|
|
||
| import spock.lang.Specification | ||
|
|
||
| class MultiSourceReaderTest extends Specification { |
There was a problem hiding this comment.
we should have a test for sourceName being null
This creates a multi source reader that can track which "source part" text comes from and map back to those places relative to each part.
The idea is that multiple files could feed a parsing document and errors reported in terms of those files not the logical place
Of course it works for a single string and presents 1 source and nothing will be relative