refactor ExecutionPath to improve performance and simplify it #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andimarek
changed the title
This was referenced May 6, 2020
bbakerman
reviewed
May 6, 2020
| } | ||
|
|
||
| public ExecutionPath getParent() { | ||
| return parent; | ||
| } |
There was a problem hiding this comment.
We have drop segment, which is basically the same, right?
Should we keep drop segment or get parent?
There was a problem hiding this comment.
I think both are ok in that one is a read style thing - tell me the parent - where was dropSegment feels like a write still thing (but its immuatble so its not)
For backwards compatibility AND understanding - I would have both
bbakerman
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically breaking change because it is public API.