Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support repeatable directives - progressive branch #1916

Closed
wants to merge 2 commits into from

Conversation

bbakerman
Copy link
Member

@bbakerman bbakerman commented May 22, 2020

I have created this support_repeatable_directives branch to incorporate the great work done in PR #1915

Since this work is not complete I wanted to create a long lived central branch that further work could be pushed to.

@dugenkui03 can you base any future work off this branch. We will merge master on to it periodically.

This will allow us to work collaboratively.

The code as is does query repeatable directives

However we need to revisit the SchemaGenerator and GraphqlXXX types so that directives are truly everywhere including SDL types, We also need to put in support inside GraphqlDirective itself for the repeatable boolean.

References :

#1763

https://github.com/graphql/graphql-spec/pull/472/files

@dugenkui03
Copy link
Contributor

dugenkui03 commented May 22, 2020

Thanks for your suggestions and review. It will be great with your support.
More work in #1986 .

@bbakerman
Copy link
Member Author

See #2015

@bbakerman bbakerman closed this Aug 31, 2020
@andimarek andimarek deleted the support_repeatable_directives branch May 4, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants