273 - use builder pattern in GraphQL top level object #276
Conversation
| @@ -5,14 +5,14 @@ | |||
| public class Assert { | |||
There was a problem hiding this comment.
I know this is not related but inline assignment and null checking is super handy
| @@ -66,7 +119,7 @@ public ExecutionResult execute(String requestString, String operationName, Objec | |||
| RecognitionException recognitionException = (RecognitionException) e.getCause(); | |||
| SourceLocation sourceLocation = new SourceLocation(recognitionException.getOffendingToken().getLine(), recognitionException.getOffendingToken().getCharPositionInLine()); | |||
| InvalidSyntaxError invalidSyntaxError = new InvalidSyntaxError(sourceLocation); | |||
| return new ExecutionResultImpl(Arrays.asList(invalidSyntaxError)); | |||
| return new ExecutionResultImpl(Collections.singletonList(invalidSyntaxError)); | |||
There was a problem hiding this comment.
Smidge more efficient and IDEA inspections (which I trust mostly) says to do it.
Broken window theory in code and all...
| @@ -94,7 +94,9 @@ public class HelloWorld { | |||
| GraphQLSchema schema = GraphQLSchema.newSchema() | |||
| .query(queryType) | |||
| .build(); | |||
| Map<String, Object> result = (Map<String, Object>) new GraphQL(schema).execute("{hello}").getData(); | |||
|
|
|||
| GraphQL graphQL = GraphQL.newObject(schema).build(); | |||
There was a problem hiding this comment.
GraphQL.newGraphQL() I think is more in line with the other builder factory names. (newObject() is already "taken" by GraphQLObjectType)
| @@ -29,16 +29,69 @@ | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(GraphQL.class); | |||
|
|
|||
There was a problem hiding this comment.
I think this should take into account the mutation strategy selection, which is already released https://github.com/graphql-java/graphql-java/pull/240/files
There was a problem hiding this comment.
Yeah I am updating that now
There was a problem hiding this comment.
Ok now have updated the readme as well to give examples...plus made it the examples compile time safe.
| .query(queryType) | ||
| .build(); | ||
|
|
||
| GraphQL graphQL = GraphQL.newObject(schema).build(); |
There was a problem hiding this comment.
By default its looks the other builders and uses SimpleStrategy for execution. You can then use your own via builder methods
| @@ -29,16 +29,69 @@ | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(GraphQL.class); | |||
|
|
|||
There was a problem hiding this comment.
Ok now have updated the readme as well to give examples...plus made it the examples compile time safe.
| @@ -0,0 +1,179 @@ | |||
| package readme; | |||
There was a problem hiding this comment.
This way the readme will stay correct with the minimum effort of cut and paste
| @@ -94,7 +94,9 @@ public class HelloWorld { | |||
| GraphQLSchema schema = GraphQLSchema.newSchema() | |||
| .query(queryType) | |||
| .build(); | |||
| Map<String, Object> result = (Map<String, Object>) new GraphQL(schema).execute("{hello}").getData(); | |||
|
|
|||
| GraphQL graphQL = GraphQL.newObject(schema).build(); | |||
#273 - to allow consistency with other parts of the API and extensibility in the future, the builder pattern should be used on the GraphQL object