Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ParserOption to ignore single-line comments #2788

Merged
merged 1 commit into from Apr 16, 2022
Merged

Add ParserOption to ignore single-line comments #2788

merged 1 commit into from Apr 16, 2022

Conversation

jord1e
Copy link
Contributor

@jord1e jord1e commented Apr 9, 2022

This commit adds the ability to ignore single-line comments during AST conversion.

Fixes #2767

Always glad to help ❤️

@jord1e jord1e changed the title Add ParserOption to ignore single-line comments. Add ParserOption to ignore single-line comments Apr 9, 2022
@jord1e
Add ParserOption to ignore single-line comments
cce6205 
This commit adds the ability to ignore single-line comments during AST conversion.

Fixes graphql-java#2767
@jord1e jord1e force-pushed the ast-parser-ignore-comments branch from 15820d4 to cce6205 Compare April 9, 2022 11:33
@bbakerman bbakerman added this to the 19.0 milestone Apr 16, 2022
@bbakerman bbakerman self-requested a review April 16, 2022 00:58
bbakerman
bbakerman approved these changes Apr 16, 2022
View reviewed changes
Copy link
Member

@bbakerman bbakerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you very much for this. At some point I think we would flip the default to be "dont capture comments" but having it on for now is a sensible starting place

@bbakerman bbakerman merged commit 66595fa into graphql-java:master Apr 16, 2022
@dondonz dondonz modified the milestones: 19.0, 18.1 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbakerman bbakerman bbakerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.1
Development

Successfully merging this pull request may close these issues.

Have a parser option that prevents # comments from being collected
3 participants
@jord1e @bbakerman @dondonz