This tightens the AST compact printing #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #2869 - with tests fixed
dondonz
approved these changes
Jun 27, 2022
| @SuppressWarnings("SameParameterValue") | ||
| private <T extends Node> String jointight(List<T> nodes, String delim, String prefix, String suffix) { |
There was a problem hiding this comment.
Hyper nit: could you make it camelCase joinTight
For people with poor eyesight like me
| if (first) { | ||
| first = false; | ||
| } else { | ||
| boolean canButtTogether = lastNodeText.endsWith("}"); |
There was a problem hiding this comment.
tomgasson
reviewed
Jun 27, 2022
| output == '''{aliasOfFoo:foo(arg1:"val1",args2:"val2") @isCached {hello} world @neverCache @okThenCache} fragment FX on SomeType {aliased:field(withArgs:"argVal",andMoreArgs:"andMoreVals")}''' | ||
| isParseableAst(output) | ||
| output == '''{aliasOfFoo:foo(arg1:"val1",args2:"val2") @isCached{hello}world @neverCache @okThenCache} fragment FX on SomeType {aliased:field(withArgs:"argVal",andMoreArgs:"andMoreVals")}''' | ||
| } |
There was a problem hiding this comment.
You can also tighten directives
{foo(arg1:"val1",args2:"val2") @isCached{hello}world @neverCache @okThenCache}}
{foo(arg1:"val1",args2:"val2")@isCached{hello}world@neverCache@okThenCache}}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2869
Tests need to be fixed