Check for default value changes #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnawf
force-pushed
the
check-for-default-value-changes
branch
from
5580c8c
to
7562178
Compare
gnawf
force-pushed
the
check-for-default-value-changes
branch
from
7562178
to
532042e
Compare
gnawf
commented
Mar 31, 2023
| editOperation, List<EditOperation> editOperations, Mapping mapping) { | ||
| private void typeEdgeInsertedForInputField(EditOperation editOperation, | ||
| List<EditOperation> editOperations, | ||
| Mapping mapping) { |
| String newDefaultValue = getDefaultValueFromEdgeLabel(editOperation.getTargetEdge()); | ||
| if (!oldDefaultValue.equals(newDefaultValue)) { | ||
| getObjectModification(object.getName()).getDetails().add(new ObjectFieldArgumentDefaultValueModification(field.getName(), argument.getName(), oldDefaultValue, newDefaultValue)); | ||
| } |
There was a problem hiding this comment.
Added this, which was missing. It's done in some other cases.
|
Rebased onto master after #3156 was just merged. |
dondonz
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #3156