[WIP] Introduce QueryComplexityCalculator to allow computing complexities outside of instrumentation
#3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am more the happy for the calculator to be moved out of the intrumentation code so it can be 1 re-used and 2 better tested |
bbakerman
reviewed
Jun 2, 2023
| import static graphql.Assert.assertNotNull; | ||
| import static java.util.Optional.ofNullable; | ||
|
|
||
| public class QueryComplexityCalculator { |
|
Sorry for not coming back to this pr @bbakerman , and thank you for merging a similar solution 🙇 |
This is just your code cleaned up a fraction - thanks for the original idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks,
Opening this as a discussion rather than a complete implementation for now. We have use cases where it would be nice to be able to compute the complexity of documents outside of instrumentation. For example validating complexity on the registry of a persisted query.
The complexity calculation logic is rather simple at the moment and we could build our own using
QueryTraverser, however I'd love for the logic to be consolidated somewhere outside an instrumentation. Thoughts on extracting some of the logic to its ownQueryComplexityCalculator?Example included in this PR.